As far as I know, you should have your passport if you plan on fishing New York waters, but it's not mandatory. It would be necessary if for some reason you have to step on American soil, (e.g your boat breaks down).